Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darkside] Spacing -> Space update for CSS #3478

Merged
merged 4 commits into from
Dec 20, 2024
Merged

[Darkside] Spacing -> Space update for CSS #3478

merged 4 commits into from
Dec 20, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Dec 20, 2024

Description

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

@KenAJoh KenAJoh self-assigned this Dec 20, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 44ffd71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JulianNymark
JulianNymark approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@JulianNymark JulianNymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a mostly quick scroll through to make sure each token got *4, the alt and 05 seem to match too (maybe the only edge cases?) :shipit:

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Dec 20, 2024

Github Ai for PR-review was actually usefull for once 😮
Screenshot 2024-12-20 at 13 41 41
Screenshot 2024-12-20 at 13 41 49

@KenAJoh KenAJoh merged commit a570b78 into space-update Dec 20, 2024
1 check passed
@KenAJoh KenAJoh deleted the space-update-css branch December 20, 2024 18:29
KenAJoh added a commit that referenced this pull request Jan 8, 2025
@KenAJoh
[Darkside] Spacing token is now "Space" (#3477)
8da0af0 
* ✨ Added new space tokens

* 🚚 Updated spacing-definitions

* ✨ Added new space-tokens to old system

* ✨ Added support for new space tokens i primitives

* 🔥 Removed space-tokens from tailwindcss

* 📝 Removed old comments

* [Darkside] Spacing -> Space update for CSS (#3478)

* 🚚 Migrated to new space-token

* 📝 Add docs for temp spacing

* 🐛 Add missing token-prefix to docs

* 🐛 Remove old tests

* 🐛 Added legacy-spacing support for primitives when using new theme-stystem

* 📝 Updated JSDOC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianNymark JulianNymark JulianNymark approved these changes

Assignees

@KenAJoh KenAJoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenAJoh @JulianNymark